fix(modal): missing animated & stretched params #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ghost
added
the
|
@ddfreiling I don't think it was our intention to provide a different API for View/ViewBase.showModal(...) so I streamlined it with NativeScript/NativeScript#5734. Also, generally there are scenarios where we would like to open a modal view from ViewBase instance (e.g. TabViewItem) but it seems this functionality was not working at the moment -- made a second PR to fix it: NativeScript/NativeScript#5737 Till both PRs are merged and released I would suggest you to replace the snippet // parentView typed as ViewBase, but only View takes stretched param.
if (parentView instanceof View) {
parentView.showModal(page, context, closeCallback, fullscreen, animated, stretched);
} else {
parentView.showModal(page, context, closeCallback, fullscreen, animated);
}with // TODO: remove <any> cast after https://github.com/NativeScript/NativeScript/pull/5734 is merged
(<any>parentView).showModal(page, context, closeCallback, fullscreen, animated, stretched); |
|
@manoldonev updated to use new showModal signature |
|
@ddfreiling can you use the <any> cast above as thou the PRs are merged they are not public yet (no tns-core-modules official releases): // TODO: remove <any> cast after https://github.com/NativeScript/NativeScript/pull/5734 is merged
(<any>parentView).showModal(page, context, closeCallback, fullscreen, animated, stretched); |
showModal with all params has been merged, but awaiting new release of tns-core-modules
…ngular into fix/modal-params
|
test |
manoldonev
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
ModalDialogOptions did not include the new
animatedandstretchedparams introduced with Nativescript 4.0What is the new behavior?
ModalDialogOptions now includes optional
animatedandstretchedparamsFixes #1292
No breaking changes, no migration steps.
Question for reviewer
In dialogs.ts parentView is typed as ViewBase, but in my experience was always a View at runtime, is it safe to cast this instead of checking instanceof?